Skip to content

Set default keepalive to On #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2017
Merged

Set default keepalive to On #1434

merged 1 commit into from
May 4, 2017

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Apr 20, 2016

According to docs "In some cases this has been shown to result in an almost 50% speedup in latency times for HTML documents with many images."

Ref: http://httpd.apache.org/docs/2.4/mod/core.html#keepalive

According to docs "In some cases this has been shown to result in an almost 50% speedup in latency times for HTML documents with many images."

Ref: http://httpd.apache.org/docs/2.4/mod/core.html#keepalive
@sathieu
Copy link
Contributor Author

sathieu commented Apr 20, 2016

This is a behavior change and should be marked as such in the release notes.

@hunner hunner added this to the 2.0.0 release milestone Apr 20, 2016
@igalic
Copy link
Contributor

igalic commented Apr 21, 2016

O_o why was keepalive off to begin with?

@antaflos
Copy link
Contributor

O_o why was keepalive off to begin with?

I was asking myself the same question a few weeks ago. Especially when using Apache as an SSL-terminating reverse proxy the KeepAlive option makes a very noticeable difference in latency. IMHO this should always have been On by default, with the option to disable it on a vhost basis. I'll submit a PR for the latter.

@antaflos
Copy link
Contributor

I have submitted PR #1447.

@igalic
Copy link
Contributor

igalic commented May 7, 2016

I reckon the reason is that when this module started out 2.2 was still the default on most platforms.
we had _very bad_ defaults, wrt performance, and sometimes even security, in 2.0 and 2.2

after 2.4 came out, most distros (and, i include this module in that umbrella) were put on a spot to support this strange new behaviour (secure, fast, incompatible ;)


okay, so i went back and checked. keepalive has been On since 1.3
what's going on here??

@tphoney
Copy link
Contributor

tphoney commented Jun 16, 2016

@igalic @antaflos with the changes merged with #1447 is there any need for this pr ?

@igalic
Copy link
Contributor

igalic commented Jun 16, 2016

@tphoney yes, this should be merged into 2.x

@sathieu
Copy link
Contributor Author

sathieu commented Jun 16, 2016

Opinion: I think reasonable default performance-wise and security-wise changes can go in 1.x.

This is like 932f0d0 to me.

@igalic
Copy link
Contributor

igalic commented Jun 16, 2016

…except that with keepalive on (and the wrong keepalivetimeout setting [and the wrong mpm]) you're exposing yourself to resource starvation attacks

@hunner hunner merged commit 632dbc1 into puppetlabs:master May 4, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants